Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @RosalynHatcher hope you don't mind me nosing a bit here 😁 I wrote a quick Github Actions test flow for you (with some explanations in comments) so you can test the installation from PyPi; you can write a similar one to test the install from source, for developers. A few notes from me:
Another side-note,
cfchecks --version
returns the help docstring but not the version, I think you are not setting it correctly at argparse stage, sorry, am nagging too much 😁There is also an issue I wanted to flag: it's best you recommend users+developers (the advanced users) to install it in a virt env (either Python or Conda virt env), a la:
This is better and more secure than
python setup.py install
Anyways, hope this is useful 🍺